New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow warn logging for requests which are failures, ensure debug… #2273
Conversation
… logging level for all other requests (DEV-1255)
79489f9
to
f482cf8
Compare
✅ Linked to Story DEV-1255 · DSP-API: Add default logging to routing |
webapi/src/main/scala/org/knora/webapi/routing/AroundDirectives.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
One more thought: You might want to also warn, if the request takes more than e.g. 3 seconds. (We have some performance issues and it might be helpful to know what requests those are) |
Codecov ReportBase: 86.85% // Head: 86.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
+ Coverage 86.85% 86.99% +0.13%
==========================================
Files 241 242 +1
Lines 27967 28067 +100
==========================================
+ Hits 24292 24416 +124
+ Misses 3675 3651 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Good idea, this might be interesting to know. I will leave it out for now and may add it in a follow up PR as I want to look into our monitoring first whether this is better/easier to be exposed as a metric. |
… logging level for all other requests
Issue Number: DEV-1255
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information