Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow warn logging for requests which are failures, ensure debug… #2273

Merged
merged 2 commits into from Nov 3, 2022

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Nov 2, 2022

… logging level for all other requests

Issue Number: DEV-1255

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@seakayone seakayone force-pushed the bugfix/DEV-1255-logging-duration branch from 79489f9 to f482cf8 Compare November 2, 2022 13:17
@swarmia
Copy link

swarmia bot commented Nov 2, 2022

Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
@BalduinLandolt
Copy link
Collaborator

One more thought: You might want to also warn, if the request takes more than e.g. 3 seconds. (We have some performance issues and it might be helpful to know what requests those are)

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 86.85% // Head: 86.99% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (4f59ea2) compared to base (c5c98ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2273      +/-   ##
==========================================
+ Coverage   86.85%   86.99%   +0.13%     
==========================================
  Files         241      242       +1     
  Lines       27967    28067     +100     
==========================================
+ Hits        24292    24416     +124     
+ Misses       3675     3651      -24     
Impacted Files Coverage Δ
...c/main/scala/org/knora/webapi/core/AppServer.scala 89.55% <ø> (ø)
...ebapi/instrumentation/InstrumentationSupport.scala 100.00% <ø> (ø)
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 94.18% <100.00%> (-0.14%) ⬇️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 89.85% <100.00%> (+5.79%) ⬆️
.../org/knora/webapi/messages/OntologyConstants.scala 99.62% <100.00%> (+<0.01%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 65.38% <0.00%> (-3.85%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 69.81% <0.00%> (-1.89%) ⬇️
...r/permissionsmessages/PermissionsMessagesADM.scala 86.39% <0.00%> (-0.32%) ⬇️
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) ⬇️
...scala/org/knora/webapi/routing/Authenticator.scala 88.88% <0.00%> (-0.08%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone merged commit 92531ce into main Nov 3, 2022
@seakayone seakayone deleted the bugfix/DEV-1255-logging-duration branch November 3, 2022 08:23
@seakayone
Copy link
Collaborator Author

One more thought: You might want to also warn, if the request takes more than e.g. 3 seconds. (We have some performance issues and it might be helpful to know what requests those are)

Good idea, this might be interesting to know. I will leave it out for now and may add it in a follow up PR as I want to look into our monitoring first whether this is better/easier to be exposed as a metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants