New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: User can be project admin without being project member (DEV-1383) #2248
fix: User can be project admin without being project member (DEV-1383) #2248
Conversation
Codecov ReportBase: 86.85% // Head: 86.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2248 +/- ##
=======================================
Coverage 86.85% 86.86%
=======================================
Files 241 241
Lines 27967 27984 +17
=======================================
+ Hits 24292 24307 +15
- Misses 3675 3677 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
webapi/src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...rc/main/scala/org/knora/webapi/messages/admin/responder/usersmessages/UsersMessagesADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Show resolved
Hide resolved
Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
…ut-being-member-of-the-project
Issue Number: DEV-1383
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information