Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User can't be edited by project admin (DEV-1373) #2232

Merged
merged 22 commits into from Oct 5, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Oct 3, 2022

Issue Number: DEV-1373

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@irinaschubert irinaschubert self-assigned this Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 86.64% // Head: 86.86% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (df27b66) compared to base (71c772f).
Patch coverage: 82.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
+ Coverage   86.64%   86.86%   +0.21%     
==========================================
  Files         233      241       +8     
  Lines       28020    27969      -51     
==========================================
+ Hits        24277    24294      +17     
+ Misses       3743     3675      -68     
Impacted Files Coverage Δ
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.05% <0.00%> (-1.45%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...n/responder/groupsmessages/GroupsMessagesADM.scala 73.33% <ø> (ø)
...sponder/projectsmessages/ProjectsMessagesADM.scala 91.19% <ø> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 74.78% <ø> (-0.22%) ⬇️
...webapi/messages/util/ConstructResponseUtilV2.scala 93.29% <ø> (ø)
...a/org/knora/webapi/messages/util/MessageUtil.scala 36.66% <ø> (ø)
...knora/webapi/messages/util/PermissionUtilADM.scala 84.54% <ø> (ø)
...vsearch/types/GravsearchTypeInspectionRunner.scala 100.00% <ø> (ø)
.../webapi/messages/v2/responder/KnoraRequestV2.scala 0.00% <ø> (ø)
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@swarmia
Copy link

swarmia bot commented Oct 3, 2022

@irinaschubert irinaschubert marked this pull request as ready for review October 3, 2022 15:40
@subotic
Copy link
Collaborator

subotic commented Oct 3, 2022

@irinaschubert In general, I don't really know what the problem is that this PR is solving. Is there any issue that you can point me to that is describing the problem?

@irinaschubert irinaschubert changed the title fix: User can't be edited by project admin (DEV-1334) fix: User can't be edited by project admin (DEV-1373) Oct 3, 2022
@irinaschubert
Copy link
Author

irinaschubert commented Oct 3, 2022

@irinaschubert In general, I don't really know what the problem is that this PR is solving. Is there any issue that you can point me to that is describing the problem?

@subotic , yes, sorry, I made a mess with the branches and JIRA issues. I was working on something else first and accidentally used the same branch to fix this bug. But apart from the branch name (which I didn't manage to change without making more mess) everything should be fine. There are just some small, non-functional changes that come from the other issue (the files related to the health route). But this PR is about a bug fix: https://dasch.atlassian.net/browse/DEV-1373.

@subotic
Copy link
Collaborator

subotic commented Oct 4, 2022

@irinaschubert In general, I don't really know what the problem is that this PR is solving. Is there any issue that you can point me to that is describing the problem?

@subotic , yes, sorry, I made a mess with the branches and JIRA issues. I was working on something else first and accidentally used the same branch to fix this bug. But apart from the branch name (which I didn't manage to change without making more mess) everything should be fine. There are just some small, non-functional changes that come from the other issue (the files related to the health route). But this PR is about a bug fix: https://dasch.atlassian.net/browse/DEV-1373.

no worries. I did my share of messy PRs. Happens to everyone ;-)

@irinaschubert irinaschubert merged commit e0b1433 into main Oct 5, 2022
@irinaschubert irinaschubert deleted the wip/dev-1334-refactor-route-to-zio-layer branch October 5, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants