New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace Settings with AppConfig (DEV-1312) #2202
refactor: Replace Settings with AppConfig (DEV-1312) #2202
Conversation
✅ Linked to Story DEV-1312 · DSP-API: Remove settings and use AppConfig instead |
Codecov ReportBase: 86.64% // Head: 86.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
==========================================
+ Coverage 86.64% 86.86% +0.22%
==========================================
Files 233 241 +8
Lines 28020 28001 -19
==========================================
+ Hits 24277 24324 +47
+ Misses 3743 3677 -66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If the thing with the test setup that requires repo but no IIIF would make the tests faster, that would be even nicer... but so far so good
webapi/src/main/scala/org/knora/webapi/store/iiif/impl/IIIFServiceSipiImpl.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just check detailed comments below.
Issue Number: DEV-1312
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information