New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add code coverage #2163
build: add code coverage #2163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good and I think it is a great improvement to have better code quality. To me it's just not yet clear how we use this.
webapi/src/main/scala/org/knora/webapi/http/handler/KnoraExceptionHandler.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v1/CkanResponderV1.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v1/CkanResponderV1.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v1/CkanResponderV1.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v1/UsersResponderV1.scala
Outdated
Show resolved
Hide resolved
The same as code formatting: |
webapi/src/main/scala/org/knora/webapi/http/handler/KnoraExceptionHandler.scala
Outdated
Show resolved
Hide resolved
private implicit val stringFormatter: StringFormatter = StringFormatter.getGeneralInstance | ||
StringFormatter.getGeneralInstance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that actually work, to shove it into an implicit like this?
webapi/src/main/scala/org/knora/webapi/messages/util/standoff/StandoffTagUtilV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/GroupsResponderADM.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw that there is a file sonar-project.properties
which could probably be deleted in this PR?
ok, so this look like it is going to take a while to finish. Could we then merge this branch today after fixing the comments and then continue work on another branch? |
Resolves DEV-790
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information