Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add code coverage #2163

Merged
merged 22 commits into from Aug 25, 2022
Merged

build: add code coverage #2163

merged 22 commits into from Aug 25, 2022

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Aug 15, 2022

Resolves DEV-790

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good and I think it is a great improvement to have better code quality. To me it's just not yet clear how we use this.

@subotic
Copy link
Collaborator Author

subotic commented Aug 19, 2022

Overall it looks good and I think it is a great improvement to have better code quality. To me it's just not yet clear how we use this.

The same as code formatting: sbt fmt. Also, now VS Code will complain with yellow squiggles when something is not needed anymore.

@dasch-swiss dasch-swiss deleted a comment from sonarcloud bot Aug 22, 2022
@subotic subotic requested a review from mpro7 August 22, 2022 08:50
Makefile Outdated Show resolved Hide resolved
Comment on lines -37 to +32
private implicit val stringFormatter: StringFormatter = StringFormatter.getGeneralInstance
StringFormatter.getGeneralInstance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that actually work, to shove it into an implicit like this?

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw that there is a file sonar-project.properties which could probably be deleted in this PR?

@subotic
Copy link
Collaborator Author

subotic commented Aug 23, 2022

ok, so this look like it is going to take a while to finish. Could we then merge this branch today after fixing the comments and then continue work on another branch?

@mpro7 mpro7 merged commit b026442 into main Aug 25, 2022
@mpro7 mpro7 deleted the wip/add-codacy branch August 25, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants