Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sipi): SIPI returns 404 instead of images if cookie is invalid (DEV-1135) #2142

Merged
merged 2 commits into from Aug 2, 2022

Conversation

BalduinLandolt
Copy link
Collaborator

Resolves DEV-1135

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt changed the title add additional null checking in preflight script fix(sipi): SIPI returns 404 instead of images if cookie is invalid Aug 2, 2022
@BalduinLandolt BalduinLandolt changed the title fix(sipi): SIPI returns 404 instead of images if cookie is invalid fix(sipi): SIPI returns 404 instead of images if cookie is invalid (DEV-1135) Aug 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BalduinLandolt BalduinLandolt merged commit eb797f0 into main Aug 2, 2022
@BalduinLandolt BalduinLandolt deleted the wip/DEV-1135-images-still-show-404-error branch August 2, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants