fix(ontology): Don't accept list values without gui attribute (DEV-775) #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2022 17:33
added 2 commits
June 27, 2022 13:39
irinaschubert
changed the title
added 24 commits
June 27, 2022 14:24
added 2 commits
July 14, 2022 13:50
…te' of https://github.com/dasch-swiss/dsp-api into wip/dev-775-dont-accept-list-values-without-gui-attribute
BalduinLandolt
approved these changes
Jul 14, 2022
webapi/src/main/scala/org/knora/webapi/routing/v2/OntologiesRouteV2.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/v2/OntologiesRouteV2.scala
Outdated
Show resolved
Hide resolved
mpro7
approved these changes
Jul 14, 2022
subotic
approved these changes
Jul 15, 2022
| * | ||
| * @return either the validated list of gui attributes or a [[dsp.errors.BadRequestException]] | ||
| */ | ||
| private[valueobjects] def validateGuiObjectsPointingToList( |
There was a problem hiding this comment.
@BalduinLandolt Do you mean the package scoped private method?
|
Kudos, SonarCloud Quality Gate passed!
|
irinaschubert
deleted the
wip/dev-775-dont-accept-list-values-without-gui-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DEV-775
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: DEV-775
What is the new behavior?
Does this PR introduce a breaking change?
Other information