Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v3): add project slice (DEV-1009) #2076

Merged
merged 82 commits into from Sep 8, 2022

Conversation

BalduinLandolt
Copy link
Collaborator

Resolves DEV-1009

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-1009

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt self-assigned this Jun 14, 2022
@BalduinLandolt BalduinLandolt changed the title feat: add project slice (DEV-1009) refactor(v3): add project slice (DEV-1009) Jun 21, 2022
@BalduinLandolt BalduinLandolt marked this pull request as ready for review September 7, 2022 14:35
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly cosmetic issues found.

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalduinLandolt BalduinLandolt merged commit bd2d31e into main Sep 8, 2022
@BalduinLandolt BalduinLandolt deleted the wip/DEV-1009-create-project-slice branch September 8, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants