Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(audio): remove not required properties #2070

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Jun 2, 2022

Resolves DEV-

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kilchenmann kilchenmann self-requested a review June 8, 2022 07:06
Copy link
Contributor

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work 👍

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes in TTL files, which I see not directly related to removal duration information from audio.

…i-and-js-lib-similar-to-moving-image-file-value
@subotic
Copy link
Collaborator Author

subotic commented Jun 9, 2022

I don't understand the changes in TTL files, which I see not directly related to removal duration information from audio.

As the data inside the triplestore has changed (duration property removed), the responses from the triplestore have also changed. The order in which the triplestore returns is data is arbitrary. That's why the changes inside the generated files are mixed up.

…i-and-js-lib-similar-to-moving-image-file-value
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

…i-and-js-lib-similar-to-moving-image-file-value
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@subotic subotic merged commit 96362f4 into main Jun 11, 2022
@subotic subotic deleted the wip/DEV-770-refactor-audio-file-value-in-sipi-and-js-lib-similar-to-moving-image-file-value branch June 11, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants