Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): cache does not update correctly when an ontology is modified (DEV-939) #2068

Merged
merged 14 commits into from May 25, 2022

Conversation

BalduinLandolt
Copy link
Collaborator

Resolves DEV-939

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

After adding a class to an ontology, instances of this class cannot be found with gravsearch because the cache does not update correctly when modifying an ontology.

Issue Number: DEV-939

What is the new behavior?

The cache updates correctly

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

The naming of methods and variables is not always clear to me, but we can improve that when we refactor it.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Hope that all test will pass :)

Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.8% 8.8% Duplication

@irinaschubert irinaschubert merged commit 8541519 into main May 25, 2022
@irinaschubert irinaschubert deleted the wip/DEV-939-update-cache-on-ontology-change branch May 25, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants