Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): add list child node deletion route (DEV-729) #2064

Merged
merged 12 commits into from May 24, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented May 11, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-729

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mpro7 mpro7 self-assigned this May 11, 2022
@mpro7 mpro7 changed the title add test data feat(admin): add list child node deletion route (DEV-729) May 13, 2022
@mpro7 mpro7 marked this pull request as ready for review May 13, 2022 14:04
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all looks good. One thing should be changed though: If the node is a root node, rather than sending a query to the triplestore that doesn't do anything, this step should just be skipped.

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if everywhere we need to have the "child" in the names of the methods, classes and values. I think "node" itself would be enough. You stated in the docstrings and documentation that it is not possible to delete comments of a root node. In my opinion this should be enough.

@mpro7
Copy link
Collaborator Author

mpro7 commented May 20, 2022

@irinaschubert I have also mixed feelings about the "child" in all names, but I was already working a lot with lists and I know what messy naming is there. However I removed it and left only in info in docstrings. Now let's wait until first complaint of why it's missing :D

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions you could take over or not.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the typos that Irina has already pointed out

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@mpro7 mpro7 merged commit 179ad19 into main May 24, 2022
@mpro7 mpro7 deleted the DEV-729-add-separate-route-for-deleting-list-node-comments branch May 24, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants