Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(user): add user project (DEV-586) #2063

Merged
merged 23 commits into from Jun 13, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented May 11, 2022

Resolves DEV-586

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-586

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert changed the title add user project refactor(user): add user project (DEV-586) May 11, 2022
@irinaschubert irinaschubert marked this pull request as ready for review June 9, 2022 16:18
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

@irinaschubert irinaschubert merged commit 0c5ec03 into main Jun 13, 2022
@irinaschubert irinaschubert deleted the wip/dev-586-add-user-api-core-repo-sbt-projects branch June 13, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants