Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Problem with updating cache after deleting comments (DEV-508) #2060

Merged
merged 3 commits into from May 10, 2022
Merged

Fix: Problem with updating cache after deleting comments (DEV-508) #2060

merged 3 commits into from May 10, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented May 9, 2022 •
edited

Resolves DEV-508

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-508

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this May 9, 2022
BalduinLandolt
BalduinLandolt approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit a9fda7e into main May 10, 2022
@irinaschubert irinaschubert deleted the wip/dev-508-fix-delete-comment-from-class branch May 10, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@subotic subotic Awaiting requested review from subotic

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irinaschubert @mpro7 @BalduinLandolt