Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): allow deleting comments of properties (DEV-696) #2042

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Apr 13, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-696

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Apr 13, 2022
@irinaschubert irinaschubert marked this pull request as ready for review April 26, 2022 06:38
@irinaschubert irinaschubert changed the title feat(ontology): allow deleting comments of properties and classes (DEV-696) feat(ontology): allow deleting comments of properties (DEV-696) Apr 26, 2022
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@irinaschubert irinaschubert merged commit 985c5fd into main Apr 26, 2022
@irinaschubert irinaschubert deleted the wip/dev-696-allow-deleting-of-comments-for-properties-and-classes branch April 26, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants