Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(listsADM): add canDeleteList route #1968

Merged
merged 8 commits into from Dec 17, 2021
Merged

feat(listsADM): add canDeleteList route #1968

merged 8 commits into from Dec 17, 2021

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Dec 14, 2021

resolves DEV-145

@mpro7 mpro7 requested a review from subotic as a code owner December 14, 2021 17:19
@mpro7 mpro7 self-assigned this Dec 14, 2021
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions regarding naming.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good... I aggree with Irina's naming suggestions, and there is one typo (unused instead of used), but apart from that all fine

@mpro7 mpro7 requested a review from subotic December 17, 2021 16:36
@subotic
Copy link
Collaborator

subotic commented Dec 17, 2021

@mpro7 thanks, looks good now.

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpro7 mpro7 merged commit c276625 into main Dec 17, 2021
@mpro7 mpro7 deleted the wip/DEV-145 branch December 17, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants