Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception for inherited cardinalities (DEV-314) #1966

Merged

Conversation

irinaschubert
Copy link

resolves DEV-314

@irinaschubert irinaschubert self-assigned this Dec 14, 2021
@irinaschubert irinaschubert changed the title fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception (DEV-314) fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception for inherited cardinalities (DEV-314) Dec 14, 2021
@irinaschubert irinaschubert marked this pull request as ready for review December 15, 2021 07:29
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
61.5% 61.5% Duplication

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just to minor remarks that you can feel free to implement or ignore.
Plus maybe reconsider the PR title scope to be more on the module level.

@irinaschubert irinaschubert merged commit 55b5d4b into main Dec 16, 2021
@irinaschubert irinaschubert deleted the wip/dev-314-candeletecardinalities-on-inherited-properties branch December 16, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants