Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump sipi version (DEV-188) #1931

Merged
merged 13 commits into from Nov 3, 2021
Merged

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Nov 1, 2021

resolves DEV-188

@subotic subotic self-assigned this Nov 1, 2021
@subotic
Copy link
Collaborator Author

subotic commented Nov 1, 2021

@BalduinLandolt the changed LUA files are relevant for your BundleRepresentation PR. We need to clean this up. The distinctions there are a bit confusing.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see us needing more changes to the lua scripts. But for now, this looks good

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@subotic subotic merged commit d302b5e into main Nov 3, 2021
@subotic subotic deleted the wip/DEV-188-use-smaller-sipi-image branch November 3, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants