Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix warnings (DEV-80) #1929

Merged
merged 8 commits into from Nov 2, 2021
Merged

build: fix warnings (DEV-80) #1929

merged 8 commits into from Nov 2, 2021

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Oct 29, 2021

resolves DEV-80

@mpro7 mpro7 self-assigned this Oct 29, 2021
@mpro7 mpro7 marked this pull request as draft October 29, 2021 09:48
@mpro7 mpro7 marked this pull request as ready for review November 1, 2021 14:31
@mpro7 mpro7 changed the title WIP - fix deprecation warnings fix: Fix build warnings (DEV-80) Nov 1, 2021
@mpro7 mpro7 changed the title fix: Fix build warnings (DEV-80) fix(build): fix warnings (DEV-80) Nov 1, 2021
@mpro7 mpro7 changed the title fix(build): fix warnings (DEV-80) build: fix warnings (DEV-80) Nov 1, 2021
@mpro7 mpro7 requested a review from subotic November 1, 2021 14:43
@@ -1308,7 +1308,8 @@ object StandoffTagUtilV2 {
conventionalAttributes
) :+ StandoffTagAttribute(
key = dataTypeAttrName,
value = StandoffTagUtilV2.internalLinkMarker + internalRefTarget,
// or .toString
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.toString

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpro7 mpro7 merged commit 1368769 into main Nov 2, 2021
@mpro7 mpro7 deleted the wip/DEV-80 branch November 2, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants