New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(groups): update test data and documentation to use language specific group descriptions (DEV-123) #1921
fix(groups): update test data and documentation to use language specific group descriptions (DEV-123) #1921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What shall we do with existing groups on the test, staging and production server ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"description": "NewGroupDescription", | ||
"descriptions": [ | ||
{"value": "NewGroupDescription", "language": "en"}, | ||
{"value": "NeueGruppenBeschreibung", "language": "de"} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment: In fact this is a breaking change. But groups endpoint is not used yet (at least in dsp-app) but already implemented in js-lib.
resolves DEV-123