Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reformatting Scala files (DSP-1897) #1908

Merged
merged 2 commits into from Sep 23, 2021
Merged

refactor: reformatting Scala files (DSP-1897) #1908

merged 2 commits into from Sep 23, 2021

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Sep 23, 2021

resolves DSP-1897

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reasonably review this PR, but it looks ok as far as I can tell... and if the tests pass, then nothing is broken

@mpro7 mpro7 merged commit 8df70a2 into main Sep 23, 2021
@mpro7 mpro7 deleted the wip/DSP-1897 branch September 23, 2021 13:07
@@ -618,8 +618,8 @@ case class UserADM(
*/
def isSelf(identifier: UserIdentifierADM): Boolean = {

val iriEquals = identifier.toIriOption.contains(id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpro7 Any clue why the equal signs after the variables are not indented anymore? In my opinion, this is one of the most important formatting settings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to be at least more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants