Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add username to changeable attributes (DSP-1895) #1904

Merged
merged 3 commits into from Sep 13, 2021

Conversation

irinaschubert
Copy link

resolves DSP-1895

@irinaschubert irinaschubert self-assigned this Sep 8, 2021
@irinaschubert irinaschubert marked this pull request as ready for review September 8, 2021 15:39
status: Option[Boolean] = None,
systemAdmin: Option[Boolean] = None) {
* Represents an API request payload that asks the Knora API server to update an existing user. Information that can
* be changed include the user's username, email, given name, family name, language, password, user status, and system admin
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I've done in this file. The rest is reformatting.

Comment on lines +654 to 656
val iriEquals = identifier.toIriOption.contains(id)
val emailEquals = identifier.toEmailOption.contains(email)
val usernameEquals = identifier.toUsernameOption.contains(username)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although most of re-formatting done in the file makes sense, the one marked above I don't personally like and it's kind of the same "alignment idea" to arguments formatted here before. I opt to keep fields as it was before :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I suggest that we do the reformatting in a separate PR and then reformat everything (we already tried that but then the tests didn't run through - so we need to be careful with this). Besides, I don't know how to re-do this now... (as it was done automatically by saving the file)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's matter of the formatter configuration. It should be rather easy to revert unwanted things.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we agreed, we need to agree on the formatting rules etc. until then we should avoid reformat the code, but in this single file we can have it as a reference, which will be adjusted soon.

@irinaschubert irinaschubert merged commit 719cd0d into main Sep 13, 2021
@irinaschubert irinaschubert deleted the wip/DSP-1895-fix-documentation branch September 13, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants