New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ontology)!: use patch instead of delete for deleting cardinalities (DSP-1700) #1903
refactor(ontology)!: use patch instead of delete for deleting cardinalities (DSP-1700) #1903
Conversation
Hi @subotic , I used PATCH instead of DELETE for the deletion of cardinalities (PUT was already in use). It seems that PATCh wasn't used before so I had to enable it and also adjust the tests for these methods. I assigned the PR to you just that you can see what I did. You don't need to review it as you are on holidays. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
…-cardinalities-from-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
webapi/src/test/scala/org/knora/webapi/e2e/CORSSupportE2ESpec.scala
Outdated
Show resolved
Hide resolved
…-cardinalities-from-class
resolves DSP-1700