Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video): add support for video/mp4 to both v1 and v2 (DSP-1204) #1891

Merged
merged 2 commits into from Jul 20, 2021

Conversation

SepidehAlassi
Copy link
Contributor

resolves DSP-1204

@SepidehAlassi SepidehAlassi self-assigned this Jul 16, 2021
@SepidehAlassi SepidehAlassi added API/V1 API/V2 Sipi enhancement improve existing code or new feature labels Jul 16, 2021
@SepidehAlassi SepidehAlassi changed the title feat(videoFileValue): add support for video/mp4 to both v1 and v2 (DSP-1204) feat(video): add support for video/mp4 to both v1 and v2 (DSP-1204) Jul 16, 2021
@SepidehAlassi SepidehAlassi marked this pull request as ready for review July 18, 2021 20:30
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SepidehAlassi SepidehAlassi merged commit 83fb4b8 into main Jul 20, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1204_SupportVideoFormat branch July 20, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V1 API/V2 enhancement improve existing code or new feature Sipi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants