Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-v2, api-admin): ontology name and project name should be URL safe (DSP-1749) #1889

Merged
merged 2 commits into from Jul 14, 2021
Merged

fix(api-v2, api-admin): ontology name and project name should be URL safe (DSP-1749) #1889

merged 2 commits into from Jul 14, 2021
+70 −4

Conversation

SepidehAlassi
Copy link
Contributor

resolves DSP-1749

@SepidehAlassi SepidehAlassi self-assigned this Jul 14, 2021
@SepidehAlassi SepidehAlassi added API/Admin API/V2 bug something isn't working labels Jul 14, 2021
@SepidehAlassi SepidehAlassi marked this pull request as ready for review July 14, 2021 12:36
kilchenmann
kilchenmann approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SepidehAlassi SepidehAlassi merged commit 17601a7 into main Jul 14, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1749-ontologyAndProjectNameURLsafe branch July 14, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann kilchenmann approved these changes

Assignees

@SepidehAlassi SepidehAlassi

Labels
API/Admin API/V2 bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SepidehAlassi @kilchenmann