New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customIRIs)!: custom IRIs must contain a UUID (DSP-1763) #1884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! There are some open questions.
webapi/src/main/scala/org/knora/webapi/responders/v2/ValuesResponderV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/e2e/admin/PermissionsADME2ESpec.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/responders/v2/ResourcesResponderV2Spec.scala
Show resolved
Hide resolved
@SepidehAlassi I forgot, could you please add a section in the documentation called something like "Breaking Changes / Migration Notes" where you can add a v14 subsection and add a short sentence to describe what is happening? Don't forget: This commit needs to be merged with an exclamation mark (https://docs.dasch.swiss/developers/dsp/contribution/#type) to bump the version number to 14. |
resolves DSP-1763