New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2-ontologies): add remove cardinalities from class if property not used in resources (DSP-1700) #1869
Conversation
…perty is not used in data
…perty is not used in data
…perty is not used in data
# Conflicts: # webapi/src/main/scala/org/knora/webapi/responders/Responder.scala
@SepidehAlassi could you maybe take a look? I still need to add some tests, but the new test in |
webapi/src/main/twirl/org/knora/webapi/queries/sparql/v2/isPropertyUsed.scala.txt
Show resolved
Hide resolved
...pi/src/main/scala/org/knora/webapi/responders/v2/ontology/DeleteCardinalitiesFromClass.scala
Outdated
Show resolved
Hide resolved
...rc/test/scala/org/knora/webapi/responders/v2/ontology/DeleteCardinalitiesFromClassSpec.scala
Outdated
Show resolved
Hide resolved
@subotic you have changed the architecture of the code, this new one is very messy like Admin api, and it is hard to understand. |
…perty is not used in data
…perty is not used in data
…perty is not used in data
after adding freetest ontology to the spec
…perty is not used in data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the amount of refactoring done in this PR, it's hard to do a sensible code review. But generally it makes sense.
However, I really don't think that changes to .scalafmt.conf
should be done in a PR that is supposed to be reviewed. It's really a pain (and a waste of time) to have to dig through thousands of lines of auto-formating-changes, just to find the 50 lines that are relevant to the review.
.../main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/OntologyMessagesV2.scala
Show resolved
Hide resolved
.../main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/OntologyMessagesV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/twirl/org/knora/webapi/queries/sparql/v2/isPropertyUsed.scala.txt
Show resolved
Hide resolved
.../main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/OntologyMessagesV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/messages/v2/responder/KnoraResponseV2.scala
Show resolved
Hide resolved
.../main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/OntologyMessagesV2.scala
Outdated
Show resolved
Hide resolved
.../main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/OntologyMessagesV2.scala
Outdated
Show resolved
Hide resolved
@BalduinLandolt @irinaschubert thanks for the review. |
@irinaschubert I will merge this PR after the tests pass. |
resolves DSP-1700
OntologyResponderV2
into subpackagesfreetest
ontology toanything
projectorg.knora.webapi.responders.v2.ontology.DeleteCardinalitiesFromClass