Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Update subclasses in ontology cache when base class changes (DSP-1643) #1860

Merged
merged 5 commits into from May 19, 2021

Conversation

benjamingeer
Copy link

resolves DSP-1643

@benjamingeer benjamingeer self-assigned this May 18, 2021
@@ -1943,7 +1943,14 @@ object Cardinality extends Enumeration {
* @param guiOrder the SALSAH GUI order.
*/
case class KnoraCardinalityInfo(cardinality: Value, guiOrder: Option[Int] = None) {
override def toString: String = cardinality.toString
override def toString: String = guiOrder match {
case Some(definedGuiOrder) => s"$cardinality (guiOrder $definedGuiOrder)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks.

@benjamingeer
Copy link
Author

Thanks for your help and for the review!

@benjamingeer benjamingeer merged commit beb951d into main May 19, 2021
@benjamingeer benjamingeer deleted the fix/DSP-1643-ontology-cache branch May 19, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants