fix(gravsearch): don't move the patterns with resource IRI after topological sorting (DSP-1620) #1856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1620
For optimization of Gravsearch queries, we define a graph out of a given query for topological sorting. A resource IRI given as the subject or object of a query pattern would be a node of the graph. Therefore the topological sorting algorithm would already order these patterns properly with respect to other patterns in the query. Extra use of
moveResourceIrisToBeginning
would mess with this order, therefore now that we have topological sorting of patterns in place, this method is obsolete and has to be removed.