Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Add route for changing GUI order of cardinalities #1850

Merged
merged 10 commits into from May 3, 2021

Conversation

benjamingeer
Copy link

resolves DSP-1546

@benjamingeer benjamingeer marked this pull request as draft April 26, 2021 13:42
Benjamin Geer added 4 commits April 26, 2021 16:03
# Conflicts:
#	webapi/src/main/scala/org/knora/webapi/messages/StringFormatter.scala
#	webapi/src/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
@benjamingeer benjamingeer marked this pull request as ready for review April 27, 2021 08:40
@SepidehAlassi SepidehAlassi added API/V2 enhancement improve existing code or new feature labels Apr 29, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks.

| "owl:onProperty": {
| "@id" : "anything:hasNothingness"
| },
| "salsah-gui:guiOrder": 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this indentation.

Put("/v2/ontologies/guiorder", HttpEntity(RdfMediaTypes.`application/ld+json`, params)) ~> addCredentials(
BasicHttpCredentials(anythingUsername, password)) ~> ontologiesPath ~> check {
assert(status == StatusCodes.OK, response.toString)
val responseJsonDoc = responseToJsonLDDocument(response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add the response to the client test data as change-gui-order-response.json

@benjamingeer benjamingeer merged commit d8dbb4f into main May 3, 2021
@benjamingeer benjamingeer deleted the wip/DSP-1546_updateGuiOrderRoute branch May 3, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants