Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Improve error message when an XSLT transformation file is not found (DSP-1404) #1831

Merged
merged 6 commits into from Mar 15, 2021

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Mar 12, 2021

If a default XSL transformation isn't found for a standoff mapping, returns an error message like:

org.knora.webapi.exceptions.SipiException: Default XSL transformation
<http://rdfh.ch/0801/smVjS18pSpyBm_TeTiXuoA> not found for mapping
<http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF/mappings/leooLetterMapping>:
Unable to get file http://sipi:1024/0801/3QlCAYIGInS-G2RGy0nWAkk/file from Sipi as requested by
org.knora.webapi.responders.v2.StandoffResponderV2: Not Found"

resolves DSP-1404

@benjamingeer benjamingeer self-assigned this Mar 12, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

xslTransformation: GetXSLTransformationResponseV2 <- (responderManager ? teiHeaderXsltRequest)
.mapTo[GetXSLTransformationResponseV2]
} yield Some(xslTransformation.xslt)

xslTransformationFuture.recover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wieder was gelernt! This recover combinator is super cool :-)

@benjamingeer benjamingeer merged commit 153a674 into main Mar 15, 2021
@benjamingeer benjamingeer deleted the wip/DSP-1404-sipi branch March 15, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants