Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): add default set of permissions when creating new project (DSP-1347) #1822

Merged

Conversation

SepidehAlassi
Copy link
Contributor

resolves DSP-1347

@SepidehAlassi SepidehAlassi self-assigned this Feb 16, 2021
@SepidehAlassi SepidehAlassi added API/Admin enhancement improve existing code or new feature labels Feb 16, 2021
createRequest.forProject,
createRequest.forGroup,
requestingUser = KnoraSystemInstances.Users.SystemUser
)

_ = checkResult match {
case Some(ap) =>
case Some(ap: AdministrativePermissionADM) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor things.


// Give the members of the new project rights to modify, view, and restricted view of all resources and values
// that belong to the project.
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be named doapForProjectMember?


// Give the admins of the new project rights to change rights, modify, delete, view,
// and restricted view of all resources and values that belong to the project.
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: doapForProjectAdmin

)).mapTo[AdministrativePermissionCreateResponseADM]

// Give the members of the new project rights to create resources.
apPermissionForProjectAdmin: AdministrativePermissionCreateResponseADM <- (responderManager ? AdministrativePermissionCreateRequestADM(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apPermissionsForProjectAdmin -> apPermissionsForProjectMember

@SepidehAlassi
Copy link
Contributor Author

@subotic Thanks for reviewing this and pointing out the typos! :-D

@SepidehAlassi SepidehAlassi merged commit b7c71ca into main Feb 17, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1347-defaultSetOfPermissionsWhenCreatingProject branch February 17, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/Admin enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants