New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(projects): add default set of permissions when creating new project (DSP-1347) #1822
feat(projects): add default set of permissions when creating new project (DSP-1347) #1822
Conversation
…roject Admin and members for operations on entities that belong to this project.
…for a new project
…g to create a permission
createRequest.forProject, | ||
createRequest.forGroup, | ||
requestingUser = KnoraSystemInstances.Users.SystemUser | ||
) | ||
|
||
_ = checkResult match { | ||
case Some(ap) => | ||
case Some(ap: AdministrativePermissionADM) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few minor things.
|
||
// Give the members of the new project rights to modify, view, and restricted view of all resources and values | ||
// that belong to the project. | ||
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be named doapForProjectMember
?
|
||
// Give the admins of the new project rights to change rights, modify, delete, view, | ||
// and restricted view of all resources and values that belong to the project. | ||
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: doapForProjectAdmin
)).mapTo[AdministrativePermissionCreateResponseADM] | ||
|
||
// Give the members of the new project rights to create resources. | ||
apPermissionForProjectAdmin: AdministrativePermissionCreateResponseADM <- (responderManager ? AdministrativePermissionCreateRequestADM( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apPermissionsForProjectAdmin -> apPermissionsForProjectMember
@subotic Thanks for reviewing this and pointing out the typos! :-D |
resolves DSP-1347