Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Lists): Shift the second of two children after deletion of the first (DSP-1353) #1820

Merged

Conversation

SepidehAlassi
Copy link
Contributor

resolves DSP-1353

@SepidehAlassi SepidehAlassi self-assigned this Feb 15, 2021
@SepidehAlassi SepidehAlassi added API/Admin bug something isn't working labels Feb 15, 2021
Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One good thing about off-by-one errors is that they're easy to fix. :)

Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@SepidehAlassi SepidehAlassi merged commit d92bb01 into main Feb 16, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1353-ShiftSecondNodeAfterDeletionOfFirst branch February 16, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/Admin bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants