Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make targets for adding metadata (DSP-1289) #1810

Merged
merged 8 commits into from Feb 4, 2021

Conversation

BalduinLandolt
Copy link
Collaborator

Resolves DSP-1289

@BalduinLandolt BalduinLandolt self-assigned this Feb 3, 2021
@mpro7
Copy link
Collaborator

mpro7 commented Feb 3, 2021

Thanks @BalduinLandolt, I add my 2 Rappens here instead MD channel.

I think stack-down-delete-volumes is obsolete, because init-db-test is covering it.

I would also not include into make metadata command others than these related to metadata, because most of the time at least init-db-test would be obsolete here too. IMO into make metadata I would include just make stack-up and all possible dataset to be loaded.

@BalduinLandolt
Copy link
Collaborator Author

@mpro7 thanks for your input!

Sadly, we can only ever have one metadata set at once, since I'm loading them into the same project, otherwise they would just overwrite one another.
But yes, I'll change it right away.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review February 3, 2021 16:27
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is it, thanks!

@BalduinLandolt
Copy link
Collaborator Author

BalduinLandolt commented Feb 4, 2021

@mpro7 I moved the metadata stuff to a separate stack-up-with-metadata target. @subotic did not want me to clutter stack-up even more. Does this still seem useful to you?

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense.

@subotic
Copy link
Collaborator

subotic commented Feb 4, 2021

@BalduinLandolt I have changed the targets a bit. Could you please take a quick look and try it out?

@BalduinLandolt BalduinLandolt merged commit 9c1a70a into main Feb 4, 2021
@BalduinLandolt BalduinLandolt deleted the wip/DSP-1289-add-metadata-make-targets branch February 4, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants