Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): Delete permissions: (DSP-1169) #1787

Merged
merged 13 commits into from Jan 27, 2021

Conversation

SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Jan 15, 2021

resolves DSP-1169
Additionally:

  • For all permission operations systematically check requesting user's permission for the operation + tests

@SepidehAlassi SepidehAlassi marked this pull request as ready for review January 15, 2021 14:23
@SepidehAlassi SepidehAlassi self-assigned this Jan 21, 2021
@SepidehAlassi SepidehAlassi added API/Admin enhancement improve existing code or new feature labels Jan 21, 2021
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks :-)

@SepidehAlassi
Copy link
Contributor Author

@subotic Thanks for reviewing this!

@SepidehAlassi SepidehAlassi merged commit 3fe8c14 into main Jan 27, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1169-DeletePermissions branch January 27, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/Admin enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants