Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Generate IIIF manifest (DSP-50) #1784

Merged
merged 18 commits into from May 17, 2021

Conversation

benjamingeer
Copy link

resolves DSP-50

@benjamingeer benjamingeer added enhancement improve existing code or new feature user requirement API/V2 labels Jan 14, 2021
@benjamingeer benjamingeer self-assigned this Jan 14, 2021
@benjamingeer benjamingeer marked this pull request as draft January 14, 2021 11:46
@benjamingeer benjamingeer marked this pull request as ready for review May 6, 2021 11:54
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for the structure of the returned manifest?


for {
// Make a Gravsearch query from a template.
gravsearchQuery: String <- Future(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename this to something likequeryForIncomingLinks.

@benjamingeer
Copy link
Author

@SepidehAlassi Is this OK now?

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for all your work.

@benjamingeer
Copy link
Author

Thanks for reviewing!

@benjamingeer benjamingeer merged commit 74feb2c into main May 17, 2021
@benjamingeer benjamingeer deleted the wip/DSP-50-iiif-manifest-2 branch May 17, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 enhancement improve existing code or new feature user requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants