New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gh-ci): Release please and update gh actions (DSP-1168) #1777
feat(gh-ci): Release please and update gh actions (DSP-1168) #1777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Do I understand correctly that breaking changes now have to be indicated in two different ways:
But only the |
Yes that's correct What do you mean by "tag"? Do you mean the label? The label is now optional (https://docs.dasch.swiss/developers/dsp/contribution/#add-a-label-optional) but it could help to see corresponding code changes directly in a PR. And you can set more than one label but only one type in the title. |
Yes, OK. Can you please make some sort of announcement to make sure that everyone knows this? I had got used to the label being the thing that's machine-readable and is needed for releases. |
@benjamingeer we will announce it on the R&D channel once we are ready with all changes. |
resolves DSP-1168