Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh-ci): Release please and update gh actions (DSP-1168) #1777

Merged
merged 6 commits into from Jan 8, 2021

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jan 7, 2021

resolves DSP-1168

  • Add a changelog file. This will be updated by "release please action" after merging this PR
  • Add version.txt file. This will be updated by "release please action".
  • Add "release please action" and remove "release drafter"
  • Update github actions workflow: Separate step to deploy documentation on release --> DSP-917

@kilchenmann kilchenmann self-assigned this Jan 7, 2021
@kilchenmann kilchenmann added chore maintenance and build tasks enhancement improve existing code or new feature labels Jan 8, 2021
@kilchenmann kilchenmann changed the title feat(gh-ci): Release please and update gh actions feat(gh-ci): Release please and update gh actions (DSP-1168) Jan 8, 2021
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benjamingeer
Copy link

benjamingeer commented Jan 8, 2021

Do I understand correctly that breaking changes now have to be indicated in two different ways:

  • by an ! in a commit message
  • by a breaking tag on the PR

But only the ! affects the release version number? If that's correct, what is the tag on the PR used for? Do we need it?

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jan 8, 2021

Do I understand correctly that breaking changes now have to be indicated in two different ways:

  • by an ! in a commit message
  • by a breaking tag on the PR

But only the ! affects the release version number? If that's correct, what is the tag on the PR used for? Do we need it?

Yes that's correct

What do you mean by "tag"? Do you mean the label? The label is now optional (https://docs.dasch.swiss/developers/dsp/contribution/#add-a-label-optional) but it could help to see corresponding code changes directly in a PR. And you can set more than one label but only one type in the title.

@benjamingeer
Copy link

What do you mean by "tag"? Do you mean the label? The label is now optional

Yes, OK. Can you please make some sort of announcement to make sure that everyone knows this? I had got used to the label being the thing that's machine-readable and is needed for releases.

@mpro7
Copy link
Collaborator

mpro7 commented Jan 8, 2021

@benjamingeer we will announce it on the R&D channel once we are ready with all changes.

@kilchenmann kilchenmann merged commit 593ffab into main Jan 8, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1168-release-please-and-update-gh-actions branch January 8, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore maintenance and build tasks enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants