feat: Add an RDF processing façade (2nd iteration) (DSP-1083) #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingeer
changed the title
added 6 commits
November 18, 2020 17:22
- Move SparqlSelectResponse to RDF API, rename to SparqlSelectResult.
# Conflicts: # webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
SepidehAlassi
approved these changes
Nov 24, 2020
| } | ||
| } | ||
|
|
||
| // Wrap that Map in an ErrorHandlingMap that will gracefully report errors about missing values when they |
| @@ -906,7 +907,7 @@ class SearchResponderV2(responderData: ResponderData) extends ResponderWithStand | |||
| } | |||
|
|
|||
| prequeryResponseNotMerged.copy( | |||
| results = SparqlSelectResponseBody(prequeryRowsMerged) | |||
| results = SparqlSelectResultBody(prequeryRowsMerged) | |||
| ) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
ha, I found something. Please add an empty line here :-D
|
Thanks for the review! I will try harder to make more mistakes next time. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1083
RdfFormatUtil, and use it in:HttpTriplestoreConnector.turtleToTrigProjectsResponderADM.projectDataGetRequestADMRepositoryUpdaterRdfRepositoryfor using SPARQL to query anRdfModelin a test.SparqlSelectResponsefromTriplestoreMessagesintoorg.knora.webapi.messages.util.rdf, and rename itSparqlSelectResult, so it can be used withRdfRepository.InconsistentTriplestoreDataException->InconsistentRepositoryDataExceptionso it can be used withRdfRepository.TEIHeaderto use the RDF façade.rdf:Descriptionelements, to facilitate writing XSLT stylesheets. (Previously, you could get a mix ofrdf:Descriptionelements and typed elements, making it difficult to write XPath.)test_data/test_route/texts/beol/header.xsl(used byKnoraSipiIntegrationV1ITSpec), so it works with RDF/XML in that format.For the next PR: