Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api-v2): Switch from JSONLD-Java to Titanium #1715

Merged
merged 4 commits into from Sep 24, 2020

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Sep 23, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-458

  • Change Bazel dependencies.
  • Change JsonLDUtil to use titanium-json-ld instead of JSONLD-JAVA.
  • Remove functionality in JavaUtil that was used only with JSONLD-JAVA.
  • Remove unused method in AkkaHttpUtils that depended on JSONLD-JAVA.
  • Change JSONLDHandlingV2R2RSpec to use spray-json instead of JSONLD-JAVA.
  • Fix a bug in CreateMappingResponseV2 that Titanium found.
  • Fix tests so they don't depend on whitespace in pretty-printed JSON.
  • Update JSON-LD design doc.

@benjamingeer benjamingeer added API/V2 chore maintenance and build tasks labels Sep 23, 2020
@benjamingeer benjamingeer self-assigned this Sep 23, 2020
@benjamingeer benjamingeer changed the title refactor(api-v2): Switch from JSONLD-Java to Titanium chore(api-v2): Switch from JSONLD-Java to Titanium Sep 23, 2020
@benjamingeer benjamingeer marked this pull request as draft September 23, 2020 16:10
@benjamingeer benjamingeer marked this pull request as ready for review September 23, 2020 16:53
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@benjamingeer
Copy link
Author

Thanks for the review!

@benjamingeer benjamingeer merged commit 9e28e5b into develop Sep 24, 2020
@benjamingeer benjamingeer deleted the wip/DSP-458-titanium branch September 24, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 chore maintenance and build tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants