feat(api-v2): Accept custom new value IRI when updating value #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2020 12:02
- Make validation more strict. - Clarify tests.
SepidehAlassi
approved these changes
Sep 8, 2020
| * @param resourceID the ID of the containing resource. | ||
| * @return the validated IRI. | ||
| */ | ||
| def validateCustomValueIri(customValueIri: SmartIri, projectCode: String, resourceID: String): SmartIri = { |
There was a problem hiding this comment.
thanks for adding the validation of custom resource and value IRIs
| intValueAsInt should ===(intValue) | ||
| } | ||
|
|
||
| "not update an integer value with a custom new value version IRI that is the same as the current IRI" in { |
There was a problem hiding this comment.
Maybe in another PR, we can think about making these parameter validation tests unit tests in messages instead of e2e ones. We are trying to do so in admin API currently because e2e tests are expensive.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dasch.myjetbrains.com/youtrack/issue/DSP-543