New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-v2): Add support for text file upload (DSP-44) #1664
Conversation
- Refactor Sipi bug workaround.
Skipping
|
@benjamingeer @SepidehAlassi could you please make sure to fix this test either in this PR or as the first next thing? If you decide to ignore it in this PR, please open an issue on YouTrack. This test is also failing on |
We're planning to redesign it in the next sprint, using your idea of collecting the test data as a side effect of running the E2E tests. |
cool, great 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, please see my comment regarding work around for DSP-711
sipiResponseStr <- doSipiRequest(sipiRequest) | ||
sipiResponse: SipiKnoraJsonResponse = sipiResponseStr.parseJson.convertTo[SipiKnoraJsonResponse] | ||
|
||
// Workaround for https://dasch.myjetbrains.com/youtrack/issue/DSP-711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjamingeer it seems like Lukas has already fixed the issue of DSP-711, see his response should this workaround be removed in this PR or later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjamingeer thanks for your work. As agreed, please make a new PR with the new version of SIPI.
PR for updating Sipi: #1721 |
@SepidehAlassi Thanks for reviewing! |
https://dasch.myjetbrains.com/youtrack/issue/DSP-44
application.conf
to check that the user has uploaded the correct file type for the value type they want to create.ClientApiRouteE2ESpec
until we redesign it (https://dasch.myjetbrains.com/youtrack/issue/DSP-724).