Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gravsearch): Remove deprecated functions #1660

Merged
merged 5 commits into from Jun 28, 2020
Merged

feat(gravsearch): Remove deprecated functions #1660

merged 5 commits into from Jun 28, 2020

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Jun 19, 2020 •
edited

https://dasch.myjetbrains.com/youtrack/issue/DSP-417

This PR removes support for deprecated Gravsearch functions that can't be supported with Apache Jena Fuseki:

  • knora-api:match
  • knora-api:matchInStandoff

These have already been replaced with:

  • knora-api:matchText
  • knora-api:matchTextInStandoff

@benjamingeer benjamingeer self-assigned this Jun 19, 2020
@tobiasschweizer
Copy link
Contributor

@benjamingeer Which RC is going to contain these changes?

@benjamingeer
Copy link
Author

Hopefully in v13.0.0-rc.6?

@tobiasschweizer
Copy link
Contributor

Hopefully in v13.0.0-rc.6?

I have to refactor the Gravsearch generation in the UI anyway and I am already working on it, so that's not a problem.

@benjamingeer
Copy link
Author

I have to refactor the Gravsearch generation in the UI anyway and I am already working on it, so that's not a problem.

OK great.

@tobiasschweizer
Copy link
Contributor

tobiasschweizer commented Jun 23, 2020 •
edited

@benjamingeer Is it ok when I do the review on Thursday?

@benjamingeer
Copy link
Author

@tobiasschweizer No problem!

tobiasschweizer
tobiasschweizer reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that matchText works the same in both the simple and complex schema? With the deprecated function match, in the complex schema you had to get the string literal from the TextValue.

tobiasschweizer
tobiasschweizer approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I could answer my question myself by looking at the tests you changed :-)

@benjamingeer
Copy link
Author

Yes, sorry, the answer is yes. :)

subotic
subotic approved these changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :-)

@benjamingeer benjamingeer merged commit 5d3af46 into develop Jun 28, 2020
@benjamingeer benjamingeer deleted the wip/DSP-417-deprecated-functions branch June 28, 2020 20:11
@subotic subotic added the enhancement improve existing code or new feature label Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@benjamingeer benjamingeer

Labels
enhancement improve existing code or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjamingeer @tobiasschweizer @subotic