New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gravsearch): Remove deprecated functions #1660
Conversation
@benjamingeer Which RC is going to contain these changes? |
Hopefully in v13.0.0-rc.6? |
I have to refactor the Gravsearch generation in the UI anyway and I am already working on it, so that's not a problem. |
OK great. |
@benjamingeer Is it ok when I do the review on Thursday? |
@tobiasschweizer No problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly that matchText
works the same in both the simple and complex schema? With the deprecated function match
, in the complex schema you had to get the string literal from the TextValue
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I could answer my question myself by looking at the tests you changed :-)
Yes, sorry, the answer is yes. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks :-)
https://dasch.myjetbrains.com/youtrack/issue/DSP-417
This PR removes support for deprecated Gravsearch functions that can't be supported with Apache Jena Fuseki:
knora-api:match
knora-api:matchInStandoff
These have already been replaced with:
knora-api:matchText
knora-api:matchTextInStandoff