Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clientapi): Change signature of function to update user's system admin membership #1583

Merged
merged 2 commits into from Feb 5, 2020

Conversation

benjamingeer
Copy link

This PR changes the signature of the client API function updateUserSystemAdminMembership as requested in #1579.

Resolves #1579.

@benjamingeer benjamingeer added API/Admin clientapi frontend: Salsah, DSP-APP, BEOL, MLS, etc. labels Jan 24, 2020
@benjamingeer benjamingeer added this to the 2020-02 milestone Jan 24, 2020
@benjamingeer benjamingeer self-assigned this Jan 24, 2020
@benjamingeer benjamingeer mentioned this pull request Jan 24, 2020
@tobiasschweizer
Copy link
Contributor

Do you want me to make a PR in knora-api-js-lib that integrates this change?

@benjamingeer
Copy link
Author

Yes please

@tobiasschweizer
Copy link
Contributor

related PR: dasch-swiss/dsp-js-lib#138

@benjamingeer
Copy link
Author

@tobiasschweizer Is this OK to merge now?

@tobiasschweizer
Copy link
Contributor

I have my day off today, we can merge it tomorrow with dasch-swiss/dsp-js-lib#138.

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When you merge this PR, please also merge dasch-swiss/dsp-js-lib#138 (already approved by @kilchenmann).

@benjamingeer
Copy link
Author

Thanks @tobiasschweizer !

@benjamingeer benjamingeer merged commit c2a2559 into develop Feb 5, 2020
@benjamingeer benjamingeer deleted the wip/1579-clientapi-sysadmin branch February 5, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/Admin clientapi frontend: Salsah, DSP-APP, BEOL, MLS, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change signature of client method to update user's system admin membership
2 participants