Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where does ListNodeInfoADM.comments come from? #1508

Open
benjamingeer opened this issue Nov 8, 2019 · 1 comment
Open

Where does ListNodeInfoADM.comments come from? #1508

benjamingeer opened this issue Nov 8, 2019 · 1 comment
Assignees
@subotic
Labels
question further information is requested

Comments

@benjamingeer
Copy link

benjamingeer commented Nov 8, 2019 •
edited

ListNodeInfoADM has a member comments, which ListsResponderADM populates from rdfs:comment. But knora-base:ListNode has no cardinality on rdfs:comment.
@benjamingeer benjamingeer added the question further information is requested label Nov 8, 2019
@subotic
Copy link
Collaborator

subotic commented Nov 10, 2019

Yes, it is possible that the cardinality is not specified in knora-admin. This stems from a time, where I wasn't comfortable adding changes to then knora-base. Since it is optional, we can add it. Would you like to do it in an existing PR?

@subotic subotic added this to the Backlog milestone Feb 7, 2020
@irinaschubert irinaschubert removed this from the Backlog milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subotic subotic

Labels
question further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@subotic @benjamingeer @irinaschubert