Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong dates! #75

Open
SepidehAlassi opened this issue Nov 28, 2018 · 10 comments
Open

wrong dates! #75

SepidehAlassi opened this issue Nov 28, 2018 · 10 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SepidehAlassi
Copy link
Collaborator

Date presentations in BEOL are incorrect for some of the resources. For resource which has

"knora-api:dateValueHasCalendar": "GREGORIAN",
"knora-api:dateValueHasEndEra": "CE",
"knora-api:dateValueHasEndYear": 1786,
"knora-api:dateValueHasStartEra": "CE",
"knora-api:dateValueHasStartYear": 1786,
"knora-api:hasPermissions": "CR knora-base:Creator|M knora-base:ProjectMember|V knora-base:KnownUser|RV knora-base:UnknownUser",
"knora-api:valueAsString": "GREGORIAN:1786 CE"
Date is correct in triplestore and knora returns correct date value.
But in GUI the shown date is 1785 CE!!

screenshot 2018-11-28 16 43 46

In the new data please check the resource
http:%2F%2Frdfh.ch%2F0801%2F0TRvVX9kSyabvaD5J1_7tQ

Since the problem is not true for all resources this sounds really fishy!

@SepidehAlassi SepidehAlassi added the bug Something isn't working label Nov 28, 2018
@tobiasschweizer
Copy link
Contributor

his could be related to the native JS date object which is used for display. I will check that, too.

@tobiasschweizer
Copy link
Contributor

maybe it is because months indexes are 0 based. And there is no month here: -1 => November of the previous year.

@SepidehAlassi
Copy link
Collaborator Author

yeah it seems like it is rounding with -1 to previous year! But what puzzles me is that it does not do the same thing for all dates which have just year precision!!!!!

@tobiasschweizer
Copy link
Contributor

does it depend on the browser? we had some problems with Safari.

@SepidehAlassi
Copy link
Collaborator Author

I am using chrome

@SepidehAlassi
Copy link
Collaborator Author

@tobiasschweizer It is browser based!!! in Safari date is right!!!!!

screenshot 2018-11-28 17 09 48

@tobiasschweizer
Copy link
Contributor

Could you please make an issue in Knora-UI and assign it to @flavens, referring to this issue?

I bet it is a problem with the constructor of the date object.

@tobiasschweizer
Copy link
Contributor

the component in questions is: kui-date-value (viewer module)

@tobiasschweizer
Copy link
Contributor

@andreas-aeschlimann suspsects that it could also be a time zone related problem.

@andreas-aeschlimann
Copy link

Commented in the other thread @tobiasschweizer.

@subotic subotic added this to the Backlog milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants