Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdViewer: implementation #7

Open
1 of 2 tasks
flavens opened this issue Oct 17, 2018 · 2 comments
Open
1 of 2 tasks

osdViewer: implementation #7

flavens opened this issue Oct 17, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@flavens
Copy link
Contributor

flavens commented Oct 17, 2018

  • implementation of the osdViewer
  • adaptation for regions (cf Meditationes branch)
@flavens flavens added the enhancement New feature or request label Oct 17, 2018
@tobiasschweizer
Copy link
Contributor

in the resources template, osdviewer is loaded correctly, but there is still an error message:

screen shot 2018-10-22 at 2 43 18 pm

resource.component.html

<ul>
                <li *ngFor="let val of prop.value | key">
                <span [ngSwitch]="val.value.getClassName()">
                    <read-text-value-as-html *ngSwitchCase="KnoraConstants.ReadTextValueAsHtml" [valueObject]="val.value" [ontologyInfo]="ontologyInfo" [bindEvents]="true"></read-text-value-as-html>
                    <read-text-value-as-string *ngSwitchCase="KnoraConstants.ReadTextValueAsString" [valueObject]="val.value"></read-text-value-as-string>
                    <read-text-value-as-xml *ngSwitchCase="KnoraConstants.ReadTextValueAsXml" [valueObject]="val.value"></read-text-value-as-xml>
                    <read-date-value *ngSwitchCase="KnoraConstants.ReadDateValue" [valueObject]="val.value" [calendar]="true" [era]="true"></read-date-value>
                    <read-link-value *ngSwitchCase="KnoraConstants.ReadLinkValue" [valueObject]="val.value" [ontologyInfo]="ontologyInfo"></read-link-value>
                    <read-integer-value *ngSwitchCase="KnoraConstants.ReadIntegerValue" [valueObject]="val.value"></read-integer-value>
                    <read-decimal-value *ngSwitchCase="KnoraConstants.ReadDecimalValue" [valueObject]="val.value"></read-decimal-value>
                    <read-geom-value *ngSwitchCase="KnoraConstants.ReadGeomValue" [valueObject]="val.value"></read-geom-value>
                    <read-color-value *ngSwitchCase="KnoraConstants.ReadColorValue" [valueObject]="val.value"></read-color-value>
                    <read-uri-value *ngSwitchCase="KnoraConstants.ReadUriValue" [valueObject]="val.value"></read-uri-value>
                    <read-boolean-value *ngSwitchCase="KnoraConstants.ReadBooleanValue" [valueObject]="val.value"></read-boolean-value>
                    <read-interval-value *ngSwitchCase="KnoraConstants.ReadIntervalValue" [valueObject]="val.value"></read-interval-value>
                    <read-list-value *ngSwitchCase="KnoraConstants.ReadListValue" [valueObject]="val.value"></read-list-value>
                    <read-textfile-value *ngSwitchCase="KnoraConstants.TextFileValue" [valueObject]="val.value"></read-textfile-value>
                    <span *ngSwitchDefault="">Not supported {{val.value.getClassName()}}</span>
                </span>
                </li>
            </ul>
        </div>

        <!-- Check for incoming images -->
        <kui-still-image #OSDViewer
                       class="osd-viewer"
                       *ngIf="resource?.incomingStillImageRepresentations?.length > 0;"
                       (getImages)="changeOffsetForStillImageRepresentations($event)"
                       [images]="resource?.stillImageRepresentationsToDisplay"
                       [imageRangeStart]="0"
                       [imageRangeEnd]="4"
                       [imageChangeInterval]="5">
        </kui-still-image>

This is because osdviewer is not part of the switch case statement.

@tobiasschweizer
Copy link
Contributor

there are two cases:

  • resources as StillImageFileValues
  • resource is pointed to by StillImageFileValues

In either case, it is sufficient to display resource?.stillImageRepresentationsToDisplay since this collection will contain all relevant images (collectImagesAndRegionsForResource).

@flavens flavens added this to the Refactoring milestone Oct 25, 2018
@subotic subotic removed this from the Refactoring milestone Sep 1, 2019
@subotic subotic added this to the Backlog milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants