Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-512 support to the crypto library #6

Open
DartBot opened this issue Jun 5, 2015 · 10 comments
Open

Add SHA-512 support to the crypto library #6

DartBot opened this issue Jun 5, 2015 · 10 comments
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/1046115?v=3" align="left" width="96" height="96"hspace="10"> Issue by jwendel
Originally opened as dart-lang/sdk#9822


What steps will reproduce the problem?
The current crypto library only supports SHA-1 and a limited subset of SHA-2 (SHA-256). While this may be enough for client-side, it would be nice to have full SHA-2 support for server-side development. This would mean support for all SHA-2 algorithms: (SHA-224, SHA-256, SHA-384, SHA-512).

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
Dart SDK version 0.4.5.1_r21094

Please provide any additional information below.
I was looking to write a server-side program that talked to a RESTful service, but it required that all requests had a SHA-512 signature, which is not currently supported by the included Dart crypto library. I could also see this being needed for anyone doing a server-side Dart app that wants to store SHA-512 versions of users passwords.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Removed Type-Defect label.
Added Type-Enhancement, Area-Library, Library-Crypto, PatchesWelcome, Triaged labels.

@DartBot DartBot added type-enhancement A request for a change that isn't a bug contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) Priority-Medium labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/1046115?v=3" align="left" width="48" height="48"hspace="10"> Comment by jwendel


I'm working on these changes. I have SHA-224 and SHA-512 added and working. I have a bit of work to get all the tests added that I need/want to do.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Removed Library-Crypto label.
Added Pkg-Crypto label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Removed Area-Library label.
Added Area-Pkg label.

@gurmukhp
Copy link

Any update on this?

@Solido
Copy link

Solido commented Jan 1, 2018

This would be more than welcome since more and more API require this level of security.

@yshrsmz
Copy link

yshrsmz commented Aug 2, 2018

Trying to implement this in my project, but something is wrong 🤔
Could anyone guide me to the right direction?
I'm thinking about sending PR, once it's completed.

https://github.com/yshrsmz/bip39-dart/blob/58f51d08166929c4fb7612871e4e3506a5c2a3d1/lib/src/sha512.dart

it's based on https://github.com/jwendel/dart-sha-2

@SoptikHa2
Copy link

How is it going @yshrsmz ? Can I use the sha512.dart file in my project, is it ready?

@yshrsmz
Copy link

yshrsmz commented Dec 10, 2018

@SoptikHa2 Sadly no, but I'm now using https://github.com/PointyCastle/pointycastle/
It was not Dart2 compatible at that time, but now it is.

@jtmcdole
Copy link
Contributor

jtmcdole commented Aug 5, 2019

Should be resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants