Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite whereNotNull without sync* #273

Open
mraleph opened this issue Mar 21, 2023 · 4 comments · May be fixed by #274 or #332
Open

rewrite whereNotNull without sync* #273

mraleph opened this issue Mar 21, 2023 · 4 comments · May be fixed by #274 or #332

Comments

@mraleph
Copy link
Member

mraleph commented Mar 21, 2023

Current implementation of sync* is suboptimal and we might not get to fixing its performance in Dart 3.0 so we should probably avoid using sync* for now.

See also dart-lang/sdk#51806
@oprypin
Copy link
Member

oprypin commented May 31, 2023

FWIW a rewrite is already present in the SDK :)

dart-lang/sdk@511bf8a#diff-0a7e9eff9502b01ee867e199d3ad5ab32870afcf39b5065970e3504e7834128a
dart-lang/sdk@511bf8a#diff-5114558fe685f8eec034675a485cfeee6ff245010ea2b0c8f3f24afa1db9e4d2

@oprypin oprypin linked a pull request Jun 1, 2023 that will close this issue
Open
@lrhn
Copy link
Member

lrhn commented Jul 1, 2023

We should deprecate the version here, and make it forward to the SDK version.

@mraleph
Copy link
Member Author

mraleph commented Jul 4, 2023

Should I just abandon the PR or should I make it simply redirect to the SDK implemention (probably requires pubspec.yaml SDK constraint bump).

@lrhn
Copy link
Member

lrhn commented Jul 4, 2023

Whatever we do it should be on the 3.0 branch (which we should land RSN).

@oprypin oprypin linked a pull request Jan 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mraleph @oprypin @lrhn