Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling error with pinned tabs #10

Open
mbaz opened this issue Oct 14, 2014 · 3 comments
Open

Scrolling error with pinned tabs #10

mbaz opened this issue Oct 14, 2014 · 3 comments

Comments

@mbaz
Copy link

mbaz commented Oct 14, 2014

If I have more tabs than fit without scrolling, and then I pin a tab, then I can no longer scroll all the way up to the top tab. Also, the tab label gets shifted to the left and overlaps the tab icon.

This is on Firefox 32.0.3 and Vertical Tabs 0.2.

@jsantell
Copy link

I see this in nightly (36) as well

@AWilyFox
Copy link

AWilyFox commented Jan 3, 2015

There is a workaround for the scrolling issue. Use the patch in issue #8 :

--- a/skin/linux/linux.css  2014-09-01 19:16:43.300756000 +0300
+++ b/skin/linux/linux.css  2014-09-01 19:17:00.958383000 +0300
@@ -19,8 +19,8 @@
     margin: 0 !important;
     padding: 1px 0 !important;
     height: 24px !important;
-    min-height: 24px !important;
-    max-height: 24px !important;
+    min-height: 21px !important;
+    max-height: 21px !important;
 }

 .tabbrowser-tab[selected="true"],

@mbaz
Copy link
Author

mbaz commented Jan 5, 2015

@AWilyFox Doesn't seem to work for me on Firefox 34.0.5. I applied the patch, ran make, and reinstalled the xpi. Should I have done anything else?

DavidShepherdson pushed a commit to DavidShepherdson/VerticalTabs that referenced this issue Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants