Skip to content
This repository has been archived by the owner on Apr 18, 2020. It is now read-only.

Animated SVGs are well enough supported now that Skycons should be SVG. #11

Open
ghost opened this issue Nov 11, 2015 · 8 comments
Open

Comments

@ghost
Copy link

ghost commented Nov 11, 2015

Way, way back when we originally made Skycons, the only way to make them was by drawing to a Canvas in JavaScript. These days, animated SVGs are well-enough supported that Skycons should really just be SVG.

This would fix several issues:

  1. Heavy CPU usage on pages that include Skycons.
  2. "Blurry" rasterization of Skycons when one doesn't size the Canvas appropriately.
  3. Make it easier to customize/alter the Skycons using tools that are already built for the purpose.

We've started a skycons/svg branch for working on these. (It's slow going, though, since I very rarely have the extra hours to work on it.)

Already complete are the clear_day and clear_night Skycons. The next big task is to implement that fancy cloud, since so many of the Skycons depend on it.

@13twelve
Copy link

good luck!

@SergioCrisostomo
Copy link

👍

@SergioCrisostomo
Copy link

Was checking out the cloud in SVG: http://jsfiddle.net/s303b409/ anyone else tried to make svg icons? maybe we could get the skycons/svg branch moving forward...

@ghost
Copy link
Author

ghost commented Jan 31, 2016

@SergioCrisostomo Looks like the cloud is most of the way there... there's also a subtle stretch/shrink of each circle that makes up the cloud that'll need to go in too. Not sure when I'll have the chance to dig in, but I'll use your template as a starting place when I do!

@ghost ghost mentioned this issue Feb 17, 2016
@ghost ghost mentioned this issue Mar 28, 2016
@tech4him1
Copy link

tech4him1 commented May 22, 2017

Just wondering if something like canvas2svg would be useful.

@DenizUgur
Copy link

@tech4him1 +1 and what's the status of this PR? @ironwallaby are we ever going to receive SVG support?

@ghost
Copy link
Author

ghost commented Oct 10, 2017

Dark Sky is actively busy with other priorities at the moment, so this Issue is awaiting resources. We'd be happy to accept contributions, of course.

@JoshuaKimsey
Copy link

May I ask, do animated versions of the icons have to exactly follow the canvas versions you made, or can they be slightly different? The reason I ask is that I'm currently working on animating some static icons based on the original static icons by Adam Whitcroft that the Skycons are based on. I wanted to ask if when I finish if you'd like to include the animated SVG's in this project specifically, of if you'd just like to mention it as a fork like you did the others? I'd love to be able to contribute to animating the SVG's for this, but I'm not sure if they have to be exactly the same as the canvas versions, or if they may be somewhat different.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants