-
Notifications
You must be signed in to change notification settings - Fork 29
API requests hang indefinitely #10
Comments
It'd be helpful to know versions for Ruby, the gem, and Rails, that they are currently using. It would also be helpful to know if they're using the default HTTP adapter used by Faraday in the gem, which is Net::HTTP or if they're using another adapter like Typhoeus. If they are using the default Net::HTTP adapter, I believe the default HTTP read timeout is 60 seconds, so I would expect that a request might hang for that long and be killed, not indefinitely. |
Thanks! I'll check with them. |
@ironwallaby @czarneckid it would be nice to be able to easily customize the timeout with this gem. |
@joevandyk You should be able to do this via Faraday. See the following issue for details on how to add this customization. |
@czarneckid Looking at the issue you linked to above, I would still have to monkey patch the forecast.io gem to achieve a configurable timeout correct? It looks like Faraday only allows setting the timeout params on connection creation. |
It would just be nice if you added |
@ironwallaby I just added this PR which should completely fix the issue. It would be great to get this merged ASAP so we (and everyone) can start using timeouts if we so choose! Thanks!! |
Add optional request read timeout to Faraday [Fixes #10]
We received this from an API user:
We're not experiencing any issues directly with the API. Is there any cause that might be specific to the library or to the client that I should request from them?
The text was updated successfully, but these errors were encountered: